zDev - Tycho - OSS
  1. zDev - Tycho - OSS
  2. TYCHO-298

In maven-osgi-packaging-plugin inside configuration create an aditional parameter that lets you define the name of your zipped application and not the constant name "eclipse"

    Details

    • Type: Task Task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None
    • Global Rank:
      608

      Description

      Hi,

      Today the product-export of eclipse-application with tycho does not let you decide the name of your application (it is called "eclipse" by default).
      I think that it would be wise to add a new parameter under the configuration section which let you determine the name of your application.

      e.g.

      <plugin>
      <groupId>org.codehaus.tycho</groupId>
      <artifactId>maven-osgi-packaging-plugin</artifactId>
      <configuration>
      <productName>My Product</productName>
      <environments>
      <environment>
      <os>win32</os>
      <ws>win32</ws>
      <arch>x86</arch>
      </environment>
      </environments>
      </configuration>
      </plugin>

      i.e. the root folder of the product will be "My Product" and not "eclipse".

        Activity

        Hide
        Andreas Pakulat added a comment -

        This patch implements this feature by re-using the finalName of the project. This is already done for the final .zipfile. The new parameter is off-by-default as I've had problems building my project with Tycho once I've built Tycho itself with this option on.

        Show
        Andreas Pakulat added a comment - This patch implements this feature by re-using the finalName of the project. This is already done for the final .zipfile. The new parameter is off-by-default as I've had problems building my project with Tycho once I've built Tycho itself with this option on.
        Hide
        Igor Fedorenko added a comment -

        The patch looks good, but we're gonna need a test before we can accept it.

        Show
        Igor Fedorenko added a comment - The patch looks good, but we're gonna need a test before we can accept it.
        Hide
        Andreas Pakulat added a comment -

        Should the test go into tycho-its?

        Show
        Andreas Pakulat added a comment - Should the test go into tycho-its?
        Hide
        Igor Fedorenko added a comment -

        I think a unit test is sufficient in this case, but you can write an integration test if you want.

        ... and, btw, replace System.err.println with getLog().info or .debug

        Show
        Igor Fedorenko added a comment - I think a unit test is sufficient in this case, but you can write an integration test if you want. ... and, btw, replace System.err.println with getLog().info or .debug
        Hide
        Andreas Pakulat added a comment -

        Yeah, that one slipped by before I uploaded the diff. The next iteration won't have that output at all (as I don't think its useful)

        Show
        Andreas Pakulat added a comment - Yeah, that one slipped by before I uploaded the diff. The next iteration won't have that output at all (as I don't think its useful)
        Hide
        Andreas Pakulat added a comment -

        I've tried to look into how to write a unit-test, but being quite new to maven and tycho too I'm a bit lost how to start. In particular I don't quite get (from the existing tests in the maven-osgi-packaging-plugin project) how I can let Maven run on a dummy project and then afterwards verify that the target of the project has the apropriately named folder. Any pointers would be appreciated.

        Show
        Andreas Pakulat added a comment - I've tried to look into how to write a unit-test, but being quite new to maven and tycho too I'm a bit lost how to start. In particular I don't quite get (from the existing tests in the maven-osgi-packaging-plugin project) how I can let Maven run on a dummy project and then afterwards verify that the target of the project has the apropriately named folder. Any pointers would be appreciated.
        Hide
        Florian Albrecht added a comment -

        I created two integration tests for this (I think integration tests are required for this issue). I am quite new to git and Tycho Development, so I hope this is the right format...

        Show
        Florian Albrecht added a comment - I created two integration tests for this (I think integration tests are required for this issue). I am quite new to git and Tycho Development, so I hope this is the right format...
        Hide
        Tobias Oberlies added a comment -

        You are using the packaging type eclipse-application which is out of development. It will eventually be replaced by eclipse-product. Until eclipse-product is implemented, you'll need to build your product in an eclipse-repository packaging type. eclipse-repository (and the future eclipse-product) supports renaming the executable.

        You may still be able to convince one of the other committers to accept your patch, but I don't think that I will have time for it... (Sorry for that!)

        Show
        Tobias Oberlies added a comment - You are using the packaging type eclipse-application which is out of development. It will eventually be replaced by eclipse-product . Until eclipse-product is implemented, you'll need to build your product in an eclipse-repository packaging type. eclipse-repository (and the future eclipse-product) supports renaming the executable. You may still be able to convince one of the other committers to accept your patch, but I don't think that I will have time for it... (Sorry for that!)

          People

          • Assignee:
            Unassigned
            Reporter:
            Hoze Nadav
            Last Updated By:
            Igor Fedorenko
          • Votes:
            7 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Date of First Response: