Dev - Nexus
  1. Dev - Nexus
  2. NEXUS-5099

Memory leak in attributes upgrader when running against virtual M1 -> M2 repo

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.5
    • Fix Version/s: 2.0.6
    • Component/s: Repository
    • Labels:
      None
    • Global Rank:
      27102

      Description

      See attached screenshot, there is a very bad memory leak in the attributes upgrader.

      Not sure why it only showed up for this person, but we need to get this fixed.

      Full heap dump can be found on SUPPORT-1661

      Need this fixed ASAP since I need to get a patch out. Depending on the root cause we will need to figure out if this goes in 2.0.5.1 or 2.1.

        Activity

        Hide
        Tamás Cservenák added a comment -

        This is not a leak at all, but sadly a very old known issue of core: NEXUS-2818

        Reason and why it happened only at this instance, are the two (probably) huge M1 "shadow" repositories present in this instance (hint1: we see link items, hint2: M1 repo is "flat", making NEXUS-2818 even worse).

        Show
        Tamás Cservenák added a comment - This is not a leak at all, but sadly a very old known issue of core: NEXUS-2818 Reason and why it happened only at this instance, are the two (probably) huge M1 "shadow" repositories present in this instance (hint1: we see link items, hint2: M1 repo is "flat", making NEXUS-2818 even worse).
        Hide
        Tamás Cservenák added a comment -

        Unsure what to do here, pushing it back into TODO column until Scrum and/or talking with Rich.

        Show
        Tamás Cservenák added a comment - Unsure what to do here, pushing it back into TODO column until Scrum and/or talking with Rich.
        Hide
        Rich Seddon added a comment -

        Agreed fix is to just skip virtual m1 repos during attribute upgrade, there's no valuable information in attributes for these anyhow.

        Show
        Rich Seddon added a comment - Agreed fix is to just skip virtual m1 repos during attribute upgrade, there's no valuable information in attributes for these anyhow.
        Show
        Tamás Cservenák added a comment - https://github.com/sonatype/nexus/pull/450
        Hide
        Peter Lynch added a comment -

        tests written, now skipping shadow repos, code merged

        Show
        Peter Lynch added a comment - tests written, now skipping shadow repos, code merged

          People

          • Assignee:
            Peter Lynch
            Reporter:
            Rich Seddon
            Last Updated By:
            Rich Seddon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Date of First Response: