Uploaded image for project: 'Dev - Nexus Repo'
  1. Dev - Nexus Repo
  2. NEXUS-34246

add logging that will explain why and what blobs were not processed by the remove member from blob store group task

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.39.0, 3.38.1, 3.40.1
    • Fix Version/s: None
    • Component/s: Blobstore, Scheduled Tasks
    • Labels:
    • Story Points:
      1
    • Sprint:
      NXRM Neo Sprint 39
    • Notability:
      2
    • InvestmentLayer:
      support-escalated
    • Aha Concept:
      non-concept

      Description

      NEXUS-33795 adds logging of successful blob moves and additional DEBUG of progress.

      However the main problem we are trying to solve with additional logging is that when customer uses the task, and the complete logging from the task is as follows:

      2022-06-21 15:20:07,979-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask - Task information:
      2022-06-21 15:20:07,979-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask -  ID: c8c2630b-d927-41d9-91c4-a22acfa729b2
      2022-06-21 15:20:07,979-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask -  Type: blobstore.group.memberRemoval
      2022-06-21 15:20:07,979-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask -  Name: docker-cleanup
      2022-06-21 15:20:07,979-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask -  Description: Run blob store group member removal task
      2022-06-21 15:20:07,979-0400 DEBUG [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask - Task configuration: {.name=docker-cleanup, .id=c8c2630b-d927-41d9-91c4-a22acfa729b2, fromGroup=docker, .typeName=Admin - Remove a member from a blob store group, .visible=true, .typeId=blobstore.group.memberRemoval, .notificationCondition=SUCCESS_FAILURE, memberToRemove=docker-original, .updated=2022-06-21T15:19:59.761-04:00, .recoverable=true, .enabled=true, .alertEmail=example@example.com, .message=Run blob store group member removal task, .exposed=true, .created=2022-06-21T15:19:59.761-04:00}
      2022-06-21 15:20:07,995-0400 DEBUG [quartz-17-thread-8]  *SYSTEM org.sonatype.nexus.repository.internal.blobstore.BlobStoreManagerImpl - Updating BlobStore: docker-original with attributes: {blobStoreQuotaConfig=null, file={path=docker}, state={writable=false}}
      2022-06-21 15:20:08,011-0400 INFO  [quartz-17-thread-8]  *SYSTEM org.sonatype.nexus.blobstore.file.internal.FileBlobStoreMetricsStore - Loading blob store metrics file C:\sonatype-work\nexus3\blobs\docker\B35CDEB2-A2BFFE40-CAE693F0-A9CB9174-6A779B16-metrics.properties null
      2022-06-21 15:20:08,386-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask - Elapsed time: 413.4 ms, Total processed 0/16691
      2022-06-21 15:20:08,386-0400 DEBUG [quartz-17-thread-8]  *SYSTEM org.sonatype.nexus.repository.internal.blobstore.BlobStoreManagerImpl - Updating BlobStore: docker with attributes: {blobStoreQuotaConfig=null, group={fillPolicy=writeToFirst, members=[containers]}}
      2022-06-21 15:20:08,402-0400 DEBUG [quartz-17-thread-8]  *SYSTEM org.sonatype.nexus.repository.internal.blobstore.BlobStoreManagerImpl - Updating BlobStore: docker-original with attributes: {blobStoreQuotaConfig=null, file={path=docker}, state={writable=true}}
      2022-06-21 15:20:08,402-0400 INFO  [quartz-17-thread-8]  *SYSTEM org.sonatype.nexus.blobstore.file.internal.FileBlobStoreMetricsStore - Loading blob store metrics file C:\sonatype-work\nexus3\blobs\docker\B35CDEB2-A2BFFE40-CAE693F0-A9CB9174-6A779B16-metrics.properties null
      2022-06-21 15:20:08,402-0400 INFO  [quartz-17-thread-8]  *SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask - Task complete
      

      There is nothing logged at default log levels INFO in the task specific log or even at DEBUG that explains WHY and WHAT blobs were not processed when this is logged: Total processed 0/16691

      Expected

      Add log statements at default TASK specific log levels per ignored blob that answer WHY and WHAT blobs were not processed as it relates to this statement:

      2022-06-21 15:20:08,386-0400 INFO [quartz-17-thread-8] SYSTEM com.sonatype.nexus.blobstore.group.tasks.BlobStoreGroupMemberRemovalTask - *Elapsed time: 413.4 ms, Total processed 0/16691
      

      The WHAT should include the complete blob info, or as much as possible while ensuring the introspection and logging is performant.

      Testing notes

      You can rely on the same testing notes present in  https://issues.sonatype.org/browse/NEXUS-33795

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              leonardor Leonardo Ruiz
              Reporter:
              plynch Peter Lynch
              Last Updated By:
              Rich Seddon Rich Seddon
              Team:
              NXRM - Neo
              Owner:
              Tahir Awan Tahir Awan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response:

                  tigCommentSecurity.panel-title