Uploaded image for project: 'Dev - Nexus Repo'
  1. Dev - Nexus Repo
  2. NEXUS-13939

default task log progress ---- Mark ---- messages are missing helpful context and therefore should be removed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.6.0
    • Component/s: Logging
    • Labels:

      Description

      Starting in 3.5.0, the task specific logs ( not nexus.log ) may print messages such as this ( specific concern is about these ---- Mark ---- messages ):

      2017-08-08 16:12:33,360+0200 INFO [quartz-1-thread-2] *SYSTEM org.sonatype.nexus.repository.maven.internal.RemoveSnapshotsFacetImpl - Processing 5678 GAVs found with more than minimum 2 snapshot versions
      2017-08-08 16:13:13,231+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:14:13,231+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:15:13,230+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:16:13,230+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:17:13,231+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:18:13,230+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:19:13,231+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:20:13,231+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:21:13,230+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:22:13,230+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:23:13,231+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      2017-08-08 16:24:13,230+0200 INFO [pool-24-thread-1] *SYSTEM org.sonatype.nexus.repository.maven.tasks.RemoveSnapshotsTask - ---- Mark ----
      

      These Mark messages are not helpful because:

      • they lack context
      • they fill the logs without telling us what the task is doing
      • the thread id is different from the task thread doing the actual work
      • a thread dump can tell use where in the code the task thread is doing work specificly
      • a leading informative log message ahead of beginning any major work is a better way to summarize what work a task is about to begin
      • an end user can view task state ( ie. Running,waiting, etc) for end user visible tasks in the tasks UI

      Some tasks take days to run, and could leave 1440 of these in the log per day for no discernable value.

      Expected

      For now the simplest thing is to remove the default progress logging which prints ---- Mark ---- as a log message. In other words, there should be no periodic progress logging unless explicitly coded into a task and that log message includes task specific progress data. Any work to add more explicit progress logging should be done via another ticket.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              cpeters Collin Peters
              Reporter:
              plynch Peter Lynch
              Last Updated By:
              Peter Lynch
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response:

                  tigCommentSecurity.panel-title