Uploaded image for project: 'Dev - Nexus Repo'
  1. Dev - Nexus Repo
  2. NEXUS-10317

Set the CONNECT user-agent header value as Nexus user agent

    XMLWordPrintable

Details

    • 1
    • Sprint 74

    Description

      Regression of NEXUS-7575 from Nexus 2.

      In Nexus 3, the User-Agent value is set on CONNECT to the HTTPClient value instead of the Nexus user agent. This matters because some orgs look at the value and filter requests based on it.

      Nexus 3 CONNECT example - it is set - but incorrectly:

      2016-06-10 06:56:06,088+0200 DEBUG [qtp121677791-218] deployment org.apache.http.headers - http-outgoing-33 >> CONNECT dseasb33srnrn.cloudfront.net:443 HTTP/1.1
2016-06-10 06:56:06,089+0200 DEBUG [qtp121677791-218] deployment org.apache.http.headers - http-outgoing-33 >> Host: dseasb33srnrn.cloudfront.net
2016-06-10 06:56:06,089+0200 DEBUG [qtp121677791-218] deployment org.apache.http.headers - http-outgoing-33 >> User-Agent: Apache-HttpClient/4.5.1 (Java/1.8.0_92)
2016-06-10 06:56:06,100+0200 DEBUG [qtp121677791-218] deployment org.apache.http.headers - http-outgoing-33 << HTTP/1.1 200 Connection Established

2016-06-10 06:56:06,154+0200 DEBUG [qtp121677791-218] deployment org.apache.http.headers - http-outgoing-33 >> GET /registry-v2/docker/registry/v2/blobs/sha256/5c/5c90d4a2d1a8dfffd05ff2dd659923f0ca2d843b5e45d030e17abbcd06a11b5b/data?Expires=1465535766&Signature=Z1wEfExEewOT355ZDF4Q9yoftwyVGMhSEkixphXm8VzAGd7qL1Nq4x6hIlxj7ijTPYsQ~ymy4c9LG3KPd1TmGtGP6hBqD5qX9VRGpeFxad7ofok3hku3orHmRhrum5UZ~ne~Kmj4rZlh7jWXK2N9fx9TVFlBDXqeluMXDBKKjpM_&Key-Pair-Id=APKAJECH5M7VWIS5YZ6Q HTTP/1.1
2016-06-10 06:56:06,154+0200 DEBUG [qtp121677791-218] deployment org.apache.http.headers - http-outgoing-33 >> User-Agent: Nexus/3.0.0-03 (OSS; Linux; 3.0.101-65-default; amd64; 1.8.0_92)

      Nexus 2 CONNECT example:

      jvm 1    | 2016-06-10 10:07:51,648-0300 DEBUG [proxy-3-thread-3] admin org.apache.http.headers - http-outgoing-28 >> CONNECT repository.apache.org:443 HTTP/1.1
jvm 1    | 2016-06-10 10:07:51,648-0300 DEBUG [proxy-3-thread-3] admin org.apache.http.headers - http-outgoing-28 >> User-Agent: Nexus/2.13.0-01 (OSS; Mac OS X; 10.11.5; x86_64; 1.8.0_92)

      Expected

      • all outbound HTTP requests should have the Nexus User-Agent value NOT some other value ( unless doing this would violate a repository format protocol )

      Attachments

        Issue Links

          supercedes

          Bug - A problem which impairs or prevents the functions of the product. NEXUS-7575 User-Agent header not sent for CONNECT to httpS remotes

          • Major - Major loss of function.
          • Closed

          Activity

            People

              jtom Joe Tom
              plynch Peter Lynch
              Peter Lynch Peter Lynch
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                tigCommentSecurity.panel-title